react-native-modal-picker icon indicating copy to clipboard operation
react-native-modal-picker copied to clipboard

Published 20 hours ago • verified publisher icon d-a-n

keyboardShouldPersistTaps={true}

Open arunkumarrmrj opened this issue 7 years ago • 6 comments

Issue Description

keyboardshouldpersisttaps issue

Steps to Reproduce / Code Snippets

Load a basic app with react-native-modal-picker and react-native 0.42

Expected Results

no warning

Additional Information

React Native version: ^0.42.0 react-native-modal-picker version: ^0.0.16 Platform(s) (iOS, Android, or both?): iOS

arunkumarrmrj avatar Mar 10 '17 07:03 arunkumarrmrj

Not an ideal solution but I rolled back RN to v.0.39.2.

xchau avatar Mar 14 '17 00:03 xchau

It's just a warning about function deprecated prop. I create a PR for that. #49

eiosca avatar Mar 23 '17 18:03 eiosca

It would be nice to get this rolled into the code, to remove the warning for those of us on React Native 0.42.

Does this deprecated prop currently cause any issues? True and false are still listed on the docs, but are listed as deprecated: http://facebook.github.io/react-native/releases/0.42/docs/scrollview.html#keyboardshouldpersisttaps

jawinn avatar Mar 29 '17 17:03 jawinn

@jawinn Besides a Warning, no issues

arturnista avatar Apr 25 '17 13:04 arturnista

change the index.js in react-native-modal-picker line 134 : ScrollView keyboardShouldPersistTaps="always"

eubotas avatar Apr 27 '17 06:04 eubotas

This RN deprecation was done quite badly IMHO. If keyboardShouldPersistTaps is changed from a bool to a string, it will resolve the warning in RN 0.4x. However that change will break RN 0.3x. RN should have supported both by internally checking the type and act accordingly.

The app code will now have to detect which version of RN is running and pass different values.

peacechen avatar May 15 '17 05:05 peacechen