react-native-modal-picker icon indicating copy to clipboard operation
react-native-modal-picker copied to clipboard

Use flex to automatically size optionContainer to its contents.

Open peacechen opened this issue 8 years ago • 5 comments

This allows the modal contents to automatically fit any screen.

peacechen avatar Jan 27 '17 23:01 peacechen

merged into my fork

fabriziomoscon avatar Feb 02 '17 11:02 fabriziomoscon

Thanks @fabriziomoscon. Do you publish your fork to NPM?

I noticed that you also removed flex:1 from selectStyle for RN 0.39 compatibility: https://github.com/fabriziomoscon/react-native-modal-picker/commit/423c8a0395c0a2007cc47e99a6b39651439736b1

I haven't tested against 0.39, but if you've vetted it I'll add that change to my PR.

peacechen avatar Feb 02 '17 16:02 peacechen

At the moment my package.json has this:

"react-native-modal-picker": "fabriziomoscon/react-native-modal-picker",

I am not planning to republish it under a different name.

Yes I tested it with RN 0.39.2 on android

fabriziomoscon avatar Feb 02 '17 16:02 fabriziomoscon

Is there an update on getting this merged? In need of this functionality but would like to use the original repo.

jaredtibs avatar May 15 '17 01:05 jaredtibs

This repo is abandoned, I have cheery picked few PR from here in my fork since I am using this code in production.

fabriziomoscon avatar May 15 '17 07:05 fabriziomoscon