react-native-modal-picker icon indicating copy to clipboard operation
react-native-modal-picker copied to clipboard

keyboardShouldPersistTaps warning

Open rodrigofontes opened this issue 8 years ago • 5 comments

Warning: 'keyboardShouldPersistTaps={true}' is deprecated. Use 'keyboardShouldPersistTaps="always"' instead

rodrigofontes avatar Jan 27 '17 18:01 rodrigofontes

@rodrigofontes Have you found a solution to this issue yet? I had this component working great before updating RN and dependencies.

Mjuk-Biltvatt avatar Jan 31 '17 16:01 Mjuk-Biltvatt

Nvm. Changed it myself on line 134 in index.js.

Mjuk-Biltvatt avatar Jan 31 '17 16:01 Mjuk-Biltvatt

@Mjuk-Biltvatt I changed the same but the warning still exists any ideas?

-NVM...just had to restart the simulator

ApolloMuses avatar Feb 03 '17 06:02 ApolloMuses

I open a pull request for this https://github.com/crisys11/react-native-modal-picker/pull/1

cristiancedenogallego avatar Feb 10 '17 18:02 cristiancedenogallego

This warning now has four open PRs #32, #40, #49, #52 that all does the same thing: appends ="always" to the keyboardShouldPersistTaps-prop in ScrollView on line 134.

The last change to this repo was in 5 July 2016, so it looks like @d-a-n have abandoned this project and none of these PR-s will ever be merged. It may be better to use and support a fork that actually maintains the code and merges PR-s.

Per 11 June 2017 it is 119 forks and many of them have fixed this issue. So if you are tired of this warning and wants updates you could use one of these.

mikaello avatar Jun 10 '17 23:06 mikaello