cznic

Results 247 comments of cznic

``` ~/src/github.com/cznic/ccir/libc> grep -nr '#define __mingw_choose_expr' math_windows_386.h:411:#define __mingw_choose_expr __builtin_choose_expr math_windows_amd64.h:329:#define __mingw_choose_expr __builtin_choose_expr ~/src/github.com/cznic/ccir/libc> grep -nr '#define __builtin_choose_expr' builtin.h:15:#define __builtin_choose_expr(a, b, c) (a) ? (b) : (c) ~/src/github.com/cznic/ccir/libc> ``` Seems defined...

> Is builtin.h still included automatically? Seems to be the case [here](https://github.com/cznic/sqlite2go/blob/eda9f5474f89d464bbf5973f185686d24115ab89/sqlite2go.go#L117) and [here](https://github.com/cznic/sqlite2go/blob/eda9f5474f89d464bbf5973f185686d24115ab89/internal/ccgo/all_test.go#L82)

> Not sure if that's the problem, but that error should be impossible since it should be expanded during expansion (to __builtin_choose_expr atleast) So there's definitely something going wrong. That...

I've added an attempt to reproduce the error in https://github.com/cznic/sqlite2go/commit/4d9ae6c171f27b8e301ab8e672291c8781691e75. Seems to work here: ``` ~/src/github.com/cznic/sqlite2go/internal/ccgo> go test -v -run Other -cc -ccgo -build -re 10.c |& tee log2 ===...

That was very helpful, using https://github.com/cznic/sqlite2go/commit/072d9cad093a93e4fd41dcf6f7bef640af4f76f2 I can now get an error: ``` ~/src/github.com/cznic/sqlite2go/internal/ccgo> go test -v -run Other -cc -ccgo -build -re 11.c -to |& tee log2 === RUN...

Now blocked on [0](https://github.com/camlistore/lock/issues/1).

Thanks! Hope Brad accepts the PR soon.

Sorry for the delay, I'm somehow losing track of Github issues. The benchmark results seem fishy to me, but I haven't studied the benchmark code. > What i can do...

@rogpeppe Thanks for the suggestions. Could you please checkout branch `issue25` (should have been named issue26, but I errored) and test and review the changes? I would like to know...

Which factoring algorithm it should implement? How should the API look like?