angular-svg-icon icon indicating copy to clipboard operation
angular-svg-icon copied to clipboard

If SVG file has fill attribute at path tag, this attribute is not working when we set fill property on [svgStyle].

Open umutdeveloper opened this issue 5 years ago • 5 comments

If SVG file has fill attribute at path tag, this attribute is not working when we set fill property on [svgStyle] because this attribute is adding fill attribute only to svg tag. But svg file has another fill propert on path tag in svg tag.

image

Originally posted by @umutcakirbm in https://github.com/czeckd/angular-svg-icon/issues/40#issuecomment-505079432

umutdeveloper avatar Jun 24 '19 16:06 umutdeveloper

If SVG file has fill attribute at path tag, this attribute is not working when we set fill property on [svgStyle] because this attribute is adding fill attribute only to svg tag. But svg file has another fill propert on path tag in svg tag.

Originally posted by @umutcakirbm in #40 (comment)

I also meet this problem, have you solved it?

TraderNayuta avatar Jan 19 '20 06:01 TraderNayuta

Its the same problem with the width and height. If you have a width and height on the svg tag and add a width and height with svgStyle the icon size will not change. Probably some svgStyles should directly be applied to the svg tag

CedricBojoly avatar Jun 26 '20 08:06 CedricBojoly

I'm not understanding what change is being asked for here. Why not just fix the SVGs you are using?

czeckd avatar Jul 08 '20 16:07 czeckd

I'm not understanding what change is being asked for here. Why not just fix the SVGs you are using?

Yeah, i think this is a better idea. Apply properties from the svg element to the path could be problematic, especially because you can have a svg with multiple paths.

filipedtristao avatar Jul 08 '20 16:07 filipedtristao