angular-svg-icon icon indicating copy to clipboard operation
angular-svg-icon copied to clipboard

Published 20 hours ago • verified publisher icon czeckd

Handle SVG sprite

Open sgruhier opened this issue 7 years ago • 5 comments

Thanks for this great component. I use it to load a bunch of icons. To minimize HTTP requests, I made an SVG sprite. This PR handle that. Any feedback are welcome.

sgruhier avatar Nov 24 '17 13:11 sgruhier

Also, unsure how unloadSvg(url:string) should work with sprites. If I understand your code, it looks as the cache is the svg file with sprites and then by individual sprite. The unload then should remove all cached sprites if the main svg is unloaded.

czeckd avatar Nov 28 '17 09:11 czeckd

Hello! How's it going? This PR seems helpful for me

katyapavlenko avatar Sep 26 '19 11:09 katyapavlenko

@katyapavlenko - the PR would need to be updated to resolve the conflicts. I do not have the time to do it myself.

czeckd avatar Sep 26 '19 16:09 czeckd

@czeckd Any change to bring this into a version? Loading SVG sprites would be a great addition.

fynnfeldpausch avatar Feb 12 '21 21:02 fynnfeldpausch

@fynnfeldpausch - No change, it would take some work to refactor to merge into master. At this point, my guess is that it would largely be a rewrite and I do not have the time to do it.

czeckd avatar Feb 12 '21 22:02 czeckd