Honza Dvorsky comments

Results 526 comments of


                                            Honza Dvorsky

Revisit server1/server2 and case1/case2 and value1/value2 naming in Servers, oneOf, allOf/anyOf

Sure, in the case of allOf and anyOf, there are some mutually incompatible schemas, but the oneOf should be able to support all 10 schemas. From the above, it seems...

Support external JSON references

Let's summon @mattpolzin for thoughts here 🙂

Revisit server1/server2 and case1/case2 and value1/value2 naming in Servers, oneOf, allOf/anyOf

Good catch, let me amend to: ```yaml - type: string pattern: '\s' - type: string pattern: '\d' ```

Support external JSON references

Thank you @mattpolzin for the thorough explanation – it really resonates with me. > this has allowed me (and I assume others as well) to use OpenAPIKit very effectively without...

Revisit server1/server2 and case1/case2 and value1/value2 naming in Servers, oneOf, allOf/anyOf

Hi @jordanebelanger, > In case of collision so far we've avoided naming entities based on their sibling entities. I.e. a name of an entity depending on a naming conflict. The...

Support external JSON references

Hi @mattpolzin, thanks for sharing your early progress! Since we don't use dereferencing in Swift OpenAPI Generator today (only for detecting cycles during a validation phase), I suspect we wouldn't...

Support external JSON references

@mattpolzin One thing that comes to mind - should the load function be async? To potentially allow network loads?

Support external JSON references

Thanks Matt, I'll need to prototype external ref support in order to be able to answer your questions above 🙂 I'll get back to you once I've done so, but...

Support external JSON references

Thanks so much @mattpolzin, we'll take a look 🙏

Over-eager validation of wildcard content types (/)

Thanks for reporting the issue - you're right, currently the generator doesn't handle content maps for bodies that contain wildcards in the content type names.