pycytominer icon indicating copy to clipboard operation
pycytominer copied to clipboard

refactor: apply bugbears linting checks

Open kenibrewer opened this issue 4 months ago • 0 comments

Description

Should be merged after #386

This applies the bugbear set of linting checks and makes appropriate fixes. The most commonly addressed linting failure that was fixed in this PR is B006. In cases where the mutable default was a list, it was replaces with an immutable tuple instead. For mutable dictionaries, the fix instead involved setting the default to None and initializing the default within the function.

What is the nature of your change?

  • [ ] Bug fix (fixes an issue).
  • [ ] Enhancement (adds functionality).
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • [ ] This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • [ ] I have read the CONTRIBUTING.md guidelines.
  • [ ] My code follows the style guidelines of this project.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] New and existing unit tests pass locally with my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have deleted all non-relevant text in this pull request template.

kenibrewer avatar Mar 30 '24 01:03 kenibrewer