QUESTION: Move on from CoffeeScript?

[pedrosanta]

Hi all,

So something has been crossing my mind over and over... at the time the work on this lib began (2015) the JS ecosystem was quite different from nowadays, and within that context I understand the benefits that CoffeeScript brought, namely, class syntax, arrow functions of sorts, and many others.

But given the latest advances of JS, namely with ES6, Promises and all, and I ponder if it wasn't beneficial from a maintenance standpoint to consider to migrate to ES6 or TypeScript?

I focus on the maintenance standpoint for two main reasons:

• By using ES6, we would make the development easier, simpler and remove the compilation/build phase.
• By using TypeScript, we would maintain the compilation/build phase, but would gain type checking.

Personally, I find the usage of CoffeeScript at this point to be more cumbersome (and make the code harder to read) than not, and between the two proposals above I'm still leaning to ES6 at this point, basically for the sake of simplicity. (We can always move on to TypeScript if we strongly feel that need later on.)

Thoughts? @cyrilis?

[cyrilis]

Hi @pedrosanta , I think porting to ES6 or Typescript is becoming more and more necessary. I agree to abandon CoffeeScript too (which is one of top 3 most dreaded language in stackoverflow 2018 survey ).

And porting to ES6 or Typescript is also a good change to refactoring some old/abandoned code, and I'm learning ES6 too. 😉

Cheers, let's do this. 🤖

[pedrosanta]

Great @cyrilis!

So, if you don't have a strong opinion between those two, I would lean to migrate to ES6 at the moment (which will already allow us to upgrade the code/syntax by a lot) – and if we feel the need later, upgrade to TypeScript.

Sounds fair?

[cyrilis]

Yeah, sounds good! 👍

Pedro Machado Santa [email protected]于2018年3月26日 周一下午6:20写道：

Great @cyrilis https://github.com/cyrilis!

So, if you don't have a strong opinion between those two, I would lean to migrate to ES6 at the moment (which will already allow us to upgrade the code/syntax by a lot) – and if we feel the need later, upgrade to TypeScript.

Sounds fair?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cyrilis/epub-gen/issues/56#issuecomment-376118197, or mute the thread https://github.com/notifications/unsubscribe-auth/ABv8zTF5mqPbxH7iVDBGZngqH3yQaPbZks5tiMDsgaJpZM4S5Q2y .

[actuallymentor]

+1 for ES6.

It would also make it easier for people like me to contribute more frequently to the repo.

[mikecook]

I'll just leave this here in case you hadn't seen it: https://github.com/decaffeinate/decaffeinate

[gcoda]

@cyrilis i just converted it to typescript, without reading code first. 😕 I did a bad job, but with "strict": true option. forked repo Looks like it works, most likely something broke, but with some understanding of internals i will do some refactoring of my mess 😉

Edit: type definitions might be helpfull with current build

[bmccann36]

👍 for typescript

[emagnier]

On my side, I'm definitely in favor of TypeScript. It will probably be a little more work to add typing, but I think it's worth it, because this will bring a lot more robust codebase for sure!

However moving first to ES6 could be a first step before going on TS.

[gcoda]

@emagnier it took less than hour to convert this to typescript, with help of decaffeinate, and few simple types, since ES6 is still valid TypeScript you can cut some corners and disable some of default checks.

check commits from my fork, gcoda/epub-gen. i will be glad to do it all over again, since i modified a lot of code for my needs without really digging in the logic.