github-action icon indicating copy to clipboard operation
github-action copied to clipboard

Add shrinkwrap support

Open 8BitJonny opened this issue 5 years ago • 4 comments

The problem

You cannot use this Github Action plugin if your project uses a shrinkwrap.json. Even if you want to fix it by providing a custom cache key line 73 in index.js will still be executed and fail the running github action.

https://github.com/cypress-io/github-action/blob/7e682f64d9972e9da5aafd95dcb0558de8381a84/index.js#L62-L90

8BitJonny avatar Feb 01 '20 16:02 8BitJonny

Could you submit a pull request - it would need to handle package lock, yarn and shrink wrap files

Sent from my iPhone

On Feb 1, 2020, at 11:25, Timon Christiansen [email protected] wrote:

 The problem

You cannot use this Github Action plugin if your project uses a shrinkwrap.json. Even if you want to fix it by providing a custom cache key line 73 in index.js will still be executed and fail the running github action.

https://github.com/cypress-io/github-action/blob/7e682f64d9972e9da5aafd95dcb0558de8381a84/index.js#L62-L90

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

bahmutov avatar Feb 01 '20 16:02 bahmutov

Yap, I'll go ahead and work on it 👍

8BitJonny avatar Feb 01 '20 16:02 8BitJonny

@8BitJonny

Yap, I'll go ahead and work on it 👍

I couldn't find any follow-up for this. Is it still relevant for you?

MikeMcC399 avatar Nov 10 '23 04:11 MikeMcC399

@MikeMcC399 Oh sorry, totally lost track of this. No its not relevant for me anymore and hence its up for grabs again

8BitJonny avatar Nov 11 '23 15:11 8BitJonny