cypress icon indicating copy to clipboard operation
cypress copied to clipboard

misc: allow HiDPI Screen running wayland to use cypress window/browser

Open azvyae opened this issue 10 months ago • 7 comments

  • Closes #20891

Additional details

  1. High demand of HiDPI Screen and multi monitor setups make people tend to use fractional scaling for each their own monitor differently. Problem happens when using chromium based app that can lead to blurriness of the UI. By providing simple flag to the electron arguments --ozone-platform=auto which literally can backwards compatible will help Wayland users to use chromium/electron without blurry texts, the flag also compatible with x11 window system if it's the only available option.

  2. Just small change to add the flag to the spawn.js file

Steps to test

It's already tested here

PR Tasks

azvyae avatar Apr 19 '24 14:04 azvyae

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 19 '24 14:04 CLAassistant

cypress-app-bot avatar Apr 19 '24 14:04 cypress-app-bot

@azvyae Thanks for the contribution! Can you add a changelog entry to this? https://github.com/cypress-io/cypress/blob/develop/guides/writing-the-cypress-changelog.md#when-to-add-an-entry

jennifer-shehane avatar Apr 19 '24 15:04 jennifer-shehane

Docs on ozone-platform flag: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ozone_overview.md

jennifer-shehane avatar Apr 19 '24 15:04 jennifer-shehane

Hey thanks @jennifer-shehane for the reply, just already fixed it. Feel free to ask if there is anything else to do

azvyae avatar Apr 19 '24 15:04 azvyae

@azvyae, the failing unit tests are now showing up properly on the CI job:

image

ryanthemanuel avatar May 07 '24 16:05 ryanthemanuel

@azvyae Will you be able to address the failing unit tests?

jennifer-shehane avatar May 21 '24 13:05 jennifer-shehane

@azvyae Will you be able to address the failing unit tests? We may need to close the PR if not addressed.

jennifer-shehane avatar Jun 03 '24 15:06 jennifer-shehane

Released in 13.13.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v13.13.3, please open a new issue.

cypress-bot[bot] avatar Aug 14 '24 14:08 cypress-bot[bot]