cypress
cypress copied to clipboard
fix: move main tab activation to puppeteer plugin
- Closes https://github.com/cypress-io/cypress/issues/28392
Additional details
Previously, we were attempting to activate the main tab before and after every command. This required the Chrome extension to be loaded and enabled, and was only useful for users who were leveraging the Puppeteer plugin. If the extension was disabled or disallowed by policy, commands would cause the runner to hang even when the Puppeteer plugin was not in use.
This PR moves tab closing behavior into the Puppeteer plugin itself, and adds some support logic to the driver and extension in order to accommodate the logic happening in a Cypress plugin rather than in the browser.
Steps to test
How has the user experience changed?
PR Tasks
- [X] Have tests been added/updated?
- [NA] Has a PR for user-facing changes been opened in
cypress-documentation
? - [NA] Have API changes been updated in the
type definitions
?
8 flaky tests on run #54067 ↗︎
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
Merge branch 'develop' into cacie/fix/main-tab-reactivation-hang | |||
Project: cypress | Commit: 948c377b6a |
||
Status: Passed | Duration: 20:15 💡 | ||
Started: Feb 16, 2024 2:14 PM | Ended: Feb 16, 2024 2:34 PM |
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
Test | Artifacts | |
---|---|---|
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
e2e/origin/basic_login.cy.ts • 1 flaky test • 5x-driver-firefox
Test | Artifacts | |||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Multi-step Auth > final auth redirects back to approval page - flat |
|
Test | Artifacts | |
---|---|---|
Launchpad: Open Mode > request for Cypress manifest > does not include `x-dependencies` header, if this is not the initial launch of Cypress |
Test Replay
Screenshots
|
global-mode.cy.ts • 1 flaky test • launchpad-e2e
Test | Artifacts | |
---|---|---|
... > can be opened |
Test Replay
Screenshots
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
... > errors > throws when waiting for 2nd response to route |
Test Replay
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
Review all test suite changes for PR #28898 ↗︎
Released in 13.6.5
.
This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v13.6.5, please open a new issue.