baseUrl slash breaks URL when trying to append query string

[Noyabronok]

Current behavior

baseUrl: https://..../xyz.html
cy.visit('?x=y')

Cypress tries to access http://.../xyz.html/?x=y

The extra slash after xyz.html breaks the request

Desired behavior

Do not add a slash at the end of the baseUrl if it's not needed, as in the case of query parameters

Test code to reproduce

NA

Cypress Version

12.3

Node version

14

Operating System

macOS 12.6.2

Debug Logs

No response

Other

Here's a temporary workaround for the problem that I came up with. Basically, explicitly providing the URL to the visit function, instead of relying on baseUrl, produces the desired behavior.

Cypress.Commands.overwrite(
  'visit',
  (originalFn, url: string, options: Partial<Cypress.VisitOptions>) => {
    options = options ?? {};
    // this is a workaround for a cypress bug that adds a / to the end of baseUrl which breaks the URL if it ends on .html
    // if you don't like this fix, there's another hack, which is to add some dummy query string to the baseUrl
    if (url?.startsWith('?')) {
      // terminal logging enabled by ELECTRON_ENABLE_LOGGING=1
      console.log('Setting baseUrl explicitly to remove unwanted /');
      options.qs = {
        ...options?.qs,
        ...Object.fromEntries(new URLSearchParams(url)),
      };
      url = Cypress.config().baseUrl;
    }

    return originalFn(url, options);
  }
);

[AtofStryker]

Hi @Noyabronok. Thank you for opening an issue. I was able to reproduce this behavior and am going to route this to a team. The reproduction link is here.

[kgartland-rstudio]

I just hit this bug as well. Are there any updates?

I'm on Cypress 12.7.0

[AtofStryker]

Hi @kgartland-rstudio. No updates as of yet. If this work does get picked up, we will be sure to update the issue.