cypress
cypress copied to clipboard
feat: Hide `projectId` section when project is not connected to dashboard
- closes https://github.com/cypress-io/cypress/issues/21806
User-facing changelog
Fix an issue where there's a visible “Project ID" section (with no projectId) when user has not connected to dashboard.
Additional details
The projectId
section should not show on the Dashboard if project has not been connected to dashboard.
Steps to test
- Open a project not set up to record to the dashboard (no projectId)
- Open “Dashboard Settings”
- Verify that there is no Project Id displayed, only an action button to connect to dashboard
How has the user experience changed?
BEFORE
When there's no projectId:
AFTER
When there's no projectId:
PR Tasks
- [ ] Have tests been added/updated?
- [ ] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
- [ ] Has a PR for user-facing changes been opened in
cypress-documentation
? - [ ] Have API changes been updated in the
type definitions
?
Thanks for taking the time to open a PR!
- Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
- Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.
Hi @marktnoonan Could you help to trigger CI build on this PR, thanks. CC: @flotwig
Nice job on this, it's pretty close - I merged in develop, which should trigger CI to see if anything is broken.
Hi @astone123 @AtofStryker kindly help to take a look at this PR
cc: @lmiller1990
I think it's beneficial to have a test for the positive case, although I see we already do have an existing test case to cover that state in
CloudSettings.cy.tsx
-> displays the project Id and Record Key sections
test,
Settings.cy.ts
-> shows the projectId section when there is a projectId and shows override from CLI
test
WDYT?
shows the projectId section when there is a projectId and shows override from CLI
Thank you for pointing those out! Sounds good to me!
This PR was pushed through Gitstart, with contributions from @raph941, @phunguyenmurcul.