cypress icon indicating copy to clipboard operation
cypress copied to clipboard

feat: Hide `projectId` section when project is not connected to dashboard

Open gitstart opened this issue 2 years ago • 3 comments

  • closes https://github.com/cypress-io/cypress/issues/21806

User-facing changelog

Fix an issue where there's a visible “Project ID" section (with no projectId) when user has not connected to dashboard.

Additional details

The projectId section should not show on the Dashboard if project has not been connected to dashboard.

Steps to test

  • Open a project not set up to record to the dashboard (no projectId)
  • Open “Dashboard Settings”
  • Verify that there is no Project Id displayed, only an action button to connect to dashboard

How has the user experience changed?

BEFORE When there's no projectId: Screenshot 2022-09-14 at 6 45 44 AM

AFTER When there's no projectId: Screenshot 2022-09-14 at 6 46 42 AM

PR Tasks

  • [ ] Have tests been added/updated?
  • [ ] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [ ] Has a PR for user-facing changes been opened in cypress-documentation?
  • [ ] Have API changes been updated in the type definitions?

gitstart avatar Sep 14 '22 05:09 gitstart

Thanks for taking the time to open a PR!

cypress-bot[bot] avatar Sep 14 '22 05:09 cypress-bot[bot]

Hi @marktnoonan Could you help to trigger CI build on this PR, thanks. CC: @flotwig

gitstart avatar Sep 14 '22 06:09 gitstart

Nice job on this, it's pretty close - I merged in develop, which should trigger CI to see if anything is broken.

lmiller1990 avatar Sep 20 '22 00:09 lmiller1990

Hi @astone123 @AtofStryker kindly help to take a look at this PR

cc: @lmiller1990

gitstart avatar Oct 17 '22 07:10 gitstart

I think it's beneficial to have a test for the positive case, although I see we already do have an existing test case to cover that state in

CloudSettings.cy.tsx -> displays the project Id and Record Key sections test, Settings.cy.ts -> shows the projectId section when there is a projectId and shows override from CLI test

WDYT?

gitstart-sourcegraph avatar Oct 18 '22 11:10 gitstart-sourcegraph

shows the projectId section when there is a projectId and shows override from CLI

Thank you for pointing those out! Sounds good to me!

AtofStryker avatar Oct 18 '22 17:10 AtofStryker

This PR was pushed through Gitstart, with contributions from @raph941, @phunguyenmurcul.

gitstart avatar Nov 03 '22 05:11 gitstart