cypress icon indicating copy to clipboard operation
cypress copied to clipboard

Issue 7306 add query custom commands

Open BlueWinds opened this issue 1 year ago • 1 comments

  • Closes

User facing changelog

Not ready for review yet.

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • [ ] Have tests been added/updated?
  • [ ] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [ ] Has a PR for user-facing changes been opened in cypress-documentation?
  • [ ] Have API changes been updated in the type definitions?

BlueWinds avatar Sep 12 '22 23:09 BlueWinds

Thanks for taking the time to open a PR!

cypress-bot[bot] avatar Sep 12 '22 23:09 cypress-bot[bot]



Test summary

4056 0 349 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 0eecaed6a8
Started Oct 5, 2022 7:32 PM
Ended Oct 5, 2022 7:44 PM
Duration 12:09 💡
OS Linux Debian - 11.4
Browser Electron 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 29 '22 17:09 cypress[bot]

Quick smoke test before review. It works as expected.

Cypress 10.9

image

issue-7306-addQuery-custom-commands

image

lmiller1990 avatar Sep 30 '22 04:09 lmiller1990

I guess this PR can close this issue since cy.ng() won't be around anymore.

chrisbreiding avatar Oct 04 '22 20:10 chrisbreiding

Ok, took longer than I'd hoped but have all tests passing (except one which I commented out with a TODO to re-enable as part of a follow-up - since this is into a feature branch, I'd like to put that off for now and start work related to .within() in a fresh PR).

BlueWinds avatar Oct 04 '22 22:10 BlueWinds

@chrisbreiding - Merged develop into issue-7306, then rebased this PR off that branch. I'll be more careful about that in the future; I thought that if I merged develop into both branches, it would work itself out, but apparently not!

BlueWinds avatar Oct 05 '22 15:10 BlueWinds