cypress
cypress copied to clipboard
Issue 7306 add query custom commands
- Closes
User facing changelog
Not ready for review yet.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
- [ ] Have tests been added/updated?
- [ ] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
- [ ] Has a PR for user-facing changes been opened in
cypress-documentation
? - [ ] Have API changes been updated in the
type definitions
?
Thanks for taking the time to open a PR!
- Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
- Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.
Test summary
Run details
Project | cypress |
Status | Passed |
Commit | 0eecaed6a8 |
Started | Oct 5, 2022 7:32 PM |
Ended | Oct 5, 2022 7:44 PM |
Duration | 12:09 💡 |
OS | Linux Debian - 11.4 |
Browser | Electron 106 |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
Quick smoke test before review. It works as expected.
Cypress 10.9
issue-7306-addQuery-custom-commands
I guess this PR can close this issue since cy.ng()
won't be around anymore.
Ok, took longer than I'd hoped but have all tests passing (except one which I commented out with a TODO to re-enable as part of a follow-up - since this is into a feature branch, I'd like to put that off for now and start work related to .within()
in a fresh PR).
@chrisbreiding - Merged develop into issue-7306, then rebased this PR off that branch. I'll be more careful about that in the future; I thought that if I merged develop into both branches, it would work itself out, but apparently not!