cypress icon indicating copy to clipboard operation
cypress copied to clipboard

chore: add warning encouraging react users to update mount function

Open lmiller1990 opened this issue 1 year ago • 2 comments

  • Closes https://github.com/cypress-io/cypress/issues/23032

User facing changelog

N/A

Additional details

Add a useful warning for users on the old React API, cypress/react, who are using React 18. They can now take advantage of the React 18 integration, cypress/react18.

Steps to test

It's a trivial change. I tested it out, here's how it looks:

Before (warning in console and command log)

image

After (no, warning in console or command log)

image

How has the user experience changed?

PR Tasks

  • [x] Have tests been added/updated?
  • [ ] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [ ] Has a PR for user-facing changes been opened in cypress-documentation?
  • [ ] Have API changes been updated in the type definitions?

lmiller1990 avatar Aug 08 '22 04:08 lmiller1990

Thanks for taking the time to open a PR!

cypress-bot[bot] avatar Aug 08 '22 04:08 cypress-bot[bot]



Test summary

4379 0 51 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 7002a6615c
Started Aug 10, 2022 4:44 PM
Ended Aug 10, 2022 4:55 PM
Duration 11:11 💡
OS Linux Debian - 11.3
Browser Firefox 99

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 08 '22 04:08 cypress[bot]

I will get this green and merge it up.

lmiller1990 avatar Aug 10 '22 12:08 lmiller1990