cypress
cypress copied to clipboard
chore: adding granular Firefox browser validation
We recently ran into an issue where Cypress failed to connect to Firefox on Windows. A bug was identified within Firefox and a fix was released with v103, but v101 and v102 were not patched. Those versions will never work with Cypress on Windows.
I wanted to ensure we could communicate this incompatibility through the app, rather than have users run into this and have to be redirected to the closed issue. However, there wasn't a clean way of marking these specific version/architecture combinations as unsupported with our current logic. So I did a bit of refactoring to allow our default browsers
objects to have an associated validator
function that can more dynamically determine Cypress support.
User facing changelog
- Stable Firefox versions 101 and 102 are now explicitly rendered as unsupported in Windows due to an unpatched browser incompatibility in those versions.
Additional details
Steps to test
We have pretty good test coverage around our minimum version checks. The new Firefox/Windows checks can be tested by installing 101 (or 102) and launching Cypress. You should see this:
![Screen Shot 2022-08-03 at 5 00 33 PM](https://user-images.githubusercontent.com/1711637/183215088-1071eda9-edfe-410e-940a-df2971f1d867.png)
103 should render as normal.
How has the user experience changed?
PR Tasks
- [X] Have tests been added/updated?
- [X] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
- [n/a] Has a PR for user-facing changes been opened in
cypress-documentation
? - [n/a] Have API changes been updated in the
type definitions
?
Thanks for taking the time to open a PR!
- Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
- Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.
Test summary
Run details
Project | cypress |
Status | Passed |
Commit | 91002089a2 |
Started | Aug 11, 2022 2:31 PM |
Ended | Aug 11, 2022 2:51 PM |
Duration | 19:28 💡 |
OS | Linux Debian - 11.3 |
Browser | Multiple |
View run in Cypress Dashboard ➡️
Flakiness
![]() |
cypress/proxy-logging.cy.ts ![]() |
2 ![]() |
|
---|---|---|---|
1 | Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second | ||
2 | Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second | ||
![]() |
next.cy.ts ![]() |
1 ![]() |
|
1 | Working with next-12.1.6 > should detect new spec |
![]() |
|
![]() |
e2e/origin/commands/assertions.cy.ts ![]() |
1 ![]() |
|
1 | cy.origin assertions > #consoleProps > .should() and .and() |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
Released in 10.5.0
.
This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v10.5.0, please open a new issue.