cypress icon indicating copy to clipboard operation
cypress copied to clipboard

fix: clear session state when changing specs in open mode

Open emilyrohrbough opened this issue 1 year ago • 2 comments

While working on persisting sessions between specs, I noticed we were incorrectly persisting sessions in open mode when navigating between specs from the in-line spec list.

User facing changelog

Corrected an issue where session state was not being reset when changing between specs in open mode. Fixed by .

How has the user experience changed?

Users switching between tests int he spec-finder should have a clean slate like in run mode.

PR Tasks

  • [x] Have tests been added/updated?
  • [x] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

emilyrohrbough avatar Aug 05 '22 19:08 emilyrohrbough

Thanks for taking the time to open a PR!

cypress-bot[bot] avatar Aug 05 '22 19:08 cypress-bot[bot]



Test summary

37974 0 469 0Flakiness 4


Run details

Project cypress
Status Passed
Commit bc927c152d
Started Aug 12, 2022 5:04 PM
Ended Aug 12, 2022 5:24 PM
Duration 20:05 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

e2e/origin/commands/actions.cy.ts Flakiness
1 cy.origin actions > #consoleProps > .submit()
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 05 '22 19:08 cypress[bot]

Released in 10.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v10.5.0, please open a new issue.

cypress-bot[bot] avatar Aug 15 '22 22:08 cypress-bot[bot]