cypress
cypress copied to clipboard
fix: missing fallback generic browser icon in some places
- Closes https://github.com/cypress-io/cypress/issues/21766
User facing changelog
Fixed an issue where fallback browser icon missing from selected state in dropdown within the AUT frame. Fixes #21766
Additional details
We are missing fallback value allBrowsersIcons.generic
when getting selected browser icon in some places.
Steps to test
- Install Brave browser, start and complete all setup steps
- Prepare target project and follow this instruction to add Brave into launching browser list.
- Start cypress app, select the target project and then select Brave browser
- Start any specs (even example specs) you will see the generic browser icon missing from header
How has the user experience changed?
Before
![image](https://user-images.githubusercontent.com/51897872/182064458-00042fe7-d517-4595-8727-45bdf1b2daa0.png)
After
![image](https://user-images.githubusercontent.com/51897872/182064805-136de17c-fe1a-45dd-9cbd-2fc23bedc3bb.png)
PR Tasks
- [x] Have tests been added/updated?
- [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
- [na] Has a PR for user-facing changes been opened in
cypress-documentation
? - [na] Have API changes been updated in the
type definitions
?
Thanks for taking the time to open a PR!
- Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
- Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.
@jennifer-shehane CircleCI pipeline is stuck at Build
step with Unauthorized
warning. Is there any action we should do to resolve it?
Thanks for the updates @gitstart, I will check what's going on with CI.
@marktnoonan The error logs in failed CI jobs are not clear to us. Could you please suggest how to reproduce them locally so we can fix it?
Hi @gitstart sorry for the lack of communication - the errors do not result from your PR. There is currently some sort of permissions issue affecting the CI runs kicked off by github users outside of the organization. This PR looks good, my plan is to babysit CI and get it merged before the next release.
Hi @marktnoonan Thank for checking. We can see all checks are passed. We are going to contribute more PRs to resolve current issues in Cypress Open Source in next times. Glad to contribute :)
This PR was pushed through Gitstart, with contributions from @phunguyenmurcul, @raph941.