cypress icon indicating copy to clipboard operation
cypress copied to clipboard

fix: missing fallback generic browser icon in some places

Open gitstart opened this issue 2 years ago • 3 comments

  • Closes https://github.com/cypress-io/cypress/issues/21766

User facing changelog

Fixed an issue where fallback browser icon missing from selected state in dropdown within the AUT frame. Fixes #21766

Additional details

We are missing fallback value allBrowsersIcons.generic when getting selected browser icon in some places.

Steps to test

  • Install Brave browser, start and complete all setup steps
  • Prepare target project and follow this instruction to add Brave into launching browser list.
  • Start cypress app, select the target project and then select Brave browser
  • Start any specs (even example specs) you will see the generic browser icon missing from header

How has the user experience changed?

Before

image

After

image

PR Tasks

  • [x] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

gitstart avatar Aug 01 '22 05:08 gitstart

Thanks for taking the time to open a PR!

cypress-bot[bot] avatar Aug 01 '22 05:08 cypress-bot[bot]

@jennifer-shehane CircleCI pipeline is stuck at Build step with Unauthorized warning. Is there any action we should do to resolve it?

gitstart avatar Aug 02 '22 10:08 gitstart

Thanks for the updates @gitstart, I will check what's going on with CI.

marktnoonan avatar Aug 05 '22 01:08 marktnoonan

@marktnoonan The error logs in failed CI jobs are not clear to us. Could you please suggest how to reproduce them locally so we can fix it?

gitstart avatar Aug 11 '22 16:08 gitstart

Hi @gitstart sorry for the lack of communication - the errors do not result from your PR. There is currently some sort of permissions issue affecting the CI runs kicked off by github users outside of the organization. This PR looks good, my plan is to babysit CI and get it merged before the next release.

marktnoonan avatar Aug 11 '22 18:08 marktnoonan

Hi @marktnoonan Thank for checking. We can see all checks are passed. We are going to contribute more PRs to resolve current issues in Cypress Open Source in next times. Glad to contribute :)

gitstart avatar Aug 12 '22 04:08 gitstart

This PR was pushed through Gitstart, with contributions from @phunguyenmurcul, @raph941.

gitstart avatar Oct 10 '22 05:10 gitstart