cypress icon indicating copy to clipboard operation
cypress copied to clipboard

chore: Intregrate runner packages.

Open sainthkh opened this issue 3 years ago • 4 comments

  • Related with #21689

User facing changelog

N/A. It's an internal code cleanup.

Additional details

  • Why was this change necessary? => These are mostly-unused legacy code.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => I migrated runner-shared and runner-ct into runner and removed unused scss files and react components.

Steps to test

packages folder structure has been changed. Run all tests to make sure that nothing has changed.

How has the user experience changed?

N/A. New contributors might not be confused with the legacy codes.

PR Tasks

  • [x] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

sainthkh avatar Aug 01 '22 02:08 sainthkh

Thanks for taking the time to open a PR!

cypress-bot[bot] avatar Aug 01 '22 02:08 cypress-bot[bot]



Test summary

37828 0 473 0Flakiness 10


Run details

Project cypress
Status Passed
Commit 993f918e7a
Started Aug 2, 2022 1:42 AM
Ended Aug 2, 2022 1:57 AM
Duration 15:33 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
4 ... > logs request + response headers
5 ... > logs Method, Status, URL, and XHR
This comment includes only the first 5 flaky tests. See all 10 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 01 '22 03:08 cypress[bot]

Are you still working on this @sainthkh or are we good to re-review and merge if green?

lmiller1990 avatar Aug 09 '22 00:08 lmiller1990

@lmiller1990 I think it's done. I'll take care of the dom issue at #23187.

sainthkh avatar Aug 10 '22 01:08 sainthkh

run-reporter seems broken. Last blocker @sainthkh :thinking:

lmiller1990 avatar Aug 10 '22 23:08 lmiller1990

@lmiller1990 It's happening because there are 4 test files inside reporter(commands/command.cy.tsx, hooks/hooks.cy.tsx, lib/tag.cy.tsx, test/test.cy.tsx), but there are 7 machines to run them. 3 of them don't have work to do. I opened an issue about this misleading message a few months ago at #22328.

I intentionally didn't fix this problem at #22326 because I thought the problem is more at the ci setting side (comment).

There are a few solutions for this problem:

  1. Change the CI setting from 7 to 2 or 3. -> I think it's better because we need less power and it's unlikely that we might need more than 2 or 3 machines for the tests.
  2. Return nothing when there is no test file. -> We need to fix the ci script. Maybe it's a different issue and open a new PR.

sainthkh avatar Aug 11 '22 02:08 sainthkh

Let's just take it down to parallelism: 2 for now. For such a small number of specs, we probably don't need it at all...

lmiller1990 avatar Aug 11 '22 03:08 lmiller1990