cypress icon indicating copy to clipboard operation
cypress copied to clipboard

Creating a system-test project without a "yarn.lock" should cause CI to fail

Open ZachJW34 opened this issue 3 years ago • 0 comments

Current behavior

A recent PR added a system test project that contained a package.json but no lock file. Doing so causes the yarn workspace @tooling/system-tests projects:yarn:install command to fail locally, but a cache hit on CI caused this step to be skipped.

Desired behavior

We should not be able to merge a PR that adds a system test project without a lock file. A tweak to the system-tests-node-modules-install should be made to guard against this.

Test code to reproduce

Create a new system-test project with only a package.json. This will fail locally when installing system-test node_modules but pass in CI.

Branch reproduction and CI Job

Cypress Version

10.1.0

Other

No response

ZachJW34 avatar Jun 13 '22 16:06 ZachJW34