cypress-skip-test icon indicating copy to clipboard operation
cypress-skip-test copied to clipboard

Published 20 hours ago • verified publisher icon cypress-io

skipOn should respect environment name

Open bahmutov opened this issue 5 years ago • 6 comments

Not just isOn

// CYPRESS_ENVIRONMENT=draft
skipOn('draft', () => { ... })

bahmutov avatar Feb 09 '20 19:02 bahmutov

Hey @bahmutov , are you accepting PRs for this issue? I've stumbled upon it and would love to have it fixed.

rafael-anachoreta avatar Mar 11 '20 10:03 rafael-anachoreta

Sure would love a pull request

Sent from my iPhone

On Mar 11, 2020, at 06:26, Rafael Anachoreta [email protected] wrote:

 Hey @bahmutov , are you accepting PRs for this issue? I've stumbled upon it and would love to have it fixed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

bahmutov avatar Mar 11 '20 12:03 bahmutov

hey @bahmutov any news? I would love to have this :)

Darex1991 avatar Aug 24 '20 14:08 Darex1991

That's my bad, I was meant to have submitted the PR. I'll get to it later today.

rafael-anachoreta avatar Sep 23 '20 09:09 rafael-anachoreta

@bahmutov I've created the PR above to address this issue. Let me know your thoughts!

rafael-anachoreta avatar Sep 23 '20 17:09 rafael-anachoreta

Is there any more news on this?

I can skip using cy.skipOn(Cypress.env('ENVIRONMENT') === 'whatever'), but it leaves a rather cryptic log message of skipOn false rather than skipOn whatever, so it's not ideal for readability…

unikitty37 avatar Jan 09 '21 13:01 unikitty37