cypress-documentation icon indicating copy to clipboard operation
cypress-documentation copied to clipboard

docs: update clashing types with jest answer

Open bchen1029 opened this issue 2 years ago • 9 comments

closes #4559 see: https://github.com/cypress-io/cypress/issues/22059 for discussion

bchen1029 avatar Jun 29 '22 17:06 bchen1029

@bchen1029 is attempting to deploy a commit to the Cypress Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 29 '22 17:06 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 29 '22 17:06 CLAassistant

Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 1100f98ac66d5a2eac49434548955a4200091d24

netlify[bot] avatar Jun 29 '22 17:06 netlify[bot]

Hoping this is a major priority! thx~

bchen1029 avatar Aug 16 '22 06:08 bchen1029

Hey @bchen1029 I also needed to add cypress to my exclude for it to work.

Not sure if it was something on my end but just in case the docs should reflect it.

{
  "exclude": ["cypress.config.ts", "cypress", "node_modules"]
}

We are using [email protected]

garmeeh avatar Aug 26 '22 08:08 garmeeh

Hey @bchen1029 I also needed to add cypress to my exclude for it to work.

Not sure if it was something on my end but just in case the docs should reflect it.

{
  "exclude": ["cypress.config.ts", "cypress", "node_modules"]
}

We are using [email protected]

@garmeeh really appreciate! just wanna confirm that I also need to add node_modules to exclude right ?

bchen1029 avatar Aug 26 '22 09:08 bchen1029

@bchen1029 sorry, I missed the notification on your reply. I wasn’t 100% sure on if node_modules should be there but seen some examples with it so added it. I don’t think it is doing any harm being there anyway.

garmeeh avatar Aug 30 '22 06:08 garmeeh

Yes, please merge this!

@maria-kravtsova @elylucas @rockindahizzy could you help merge this PR if you're free? It might be helpful for cypress users, really appreciate:)

bchen1029 avatar Sep 04 '22 12:09 bchen1029

@elylucas I'm not sure how the Vercel authorization step works?

marktnoonan avatar Oct 02 '22 19:10 marktnoonan

I created a new PR to track this since this one is so out of date https://github.com/cypress-io/cypress-documentation/pull/5514

jennifer-shehane avatar Oct 03 '23 16:10 jennifer-shehane