code-coverage icon indicating copy to clipboard operation
code-coverage copied to clipboard

feat: add explicit check against codeCoverage.expectFrontendCoverageOnly before attempting to collect backend coverage

Open funkadelic opened this issue 3 years ago • 7 comments

PR for https://github.com/cypress-io/code-coverage/issues/473. See https://github.com/cypress-io/code-coverage/issues/473 for details behind the change

funkadelic avatar Jun 25 '21 12:06 funkadelic

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 25 '21 12:06 CLAassistant

Please release a version with this change. @maartencardinaels @funkadelic

rsudarson avatar Jul 22 '21 10:07 rsudarson

@funkadelic is this PR still planned? My monitoring is showing all of these failing requests...

jogelin avatar Jul 26 '21 08:07 jogelin

@maartencardinaels thanks for the PR approval; is there anything else needed from my end to get this merged down to master & released?

funkadelic avatar Jul 27 '21 16:07 funkadelic

@maartencardinaels thanks for the PR approval; is there anything else needed from my end to get this merged down to master & released?

one of the project collaborators will have to merge this PR

mcaverick avatar Jul 28 '21 06:07 mcaverick

Could this be revisited? What steps are required to get it through?

eulersson avatar Mar 15 '22 10:03 eulersson

I forked from master and brought in the same changes @funkadelic has. Therefore the PR I created is an updated duplicate of this PR.

https://github.com/cypress-io/code-coverage/pull/555

eulersson avatar Mar 15 '22 12:03 eulersson