fix: only attach workspace when required

[willheslam]

My cypress/run CI job is currently failing due to

Directory (/home/circleci/project) you are trying to checkout to is not empty and not a git repository because the following steps are always applied:

    - attach_workspace:
        at: ~/
    - checkout

checkout should only be present when you're not attaching a workspace, but currently, attach-workspace: false doesn't stop workspaces being attached due to the broken conditional, hence the job failing if the workspace has anything inside it.

Fixes https://github.com/cypress-io/circleci-orb/issues/293

[CLAassistant]

All committers have signed the CLA.

[jennifer-shehane]

@willheslam Could you please sign our CLA?

[willheslam]

@jennifer-shehane Oops, thanks for the reminder - done!

[bayphillips-seed]

Hey @pckilgore any chance this could be merged in? We're running into this issue currently.

[pckilgore]

Hey @pckilgore any chance this could be merged in? We're running into this issue currently.

Don't work for Cypress

[benedfit]

Do you have an ETA for when this will be released?