cypht icon indicating copy to clipboard operation
cypht copied to clipboard

improve JMAP compatibilities with stalwart

Open Shadow243 opened this issue 1 year ago • 3 comments

This Pull Request follows a proposal that had been made: https://github.com/cypht-org/cypht/pull/648 adding support for JMAP in Cypht.

Shadow243 avatar Feb 19 '24 11:02 Shadow243

Currently, we have left it as draft pending this fix https://github.com/cypht-org/cypht/pull/902 which will fix email sending as it is not working for now. We have been not able to test send mail

Shadow243 avatar Feb 19 '24 11:02 Shadow243

fwiw it seems 4bc4cea reverts the previous commits in hm-jmap

landryb avatar Feb 23 '24 10:02 landryb

fwiw it seems 4bc4cea reverts the previous commits in hm-jmap

We started with your commits then added another, we now have your 4 commits plus 1(5 commits)

Shadow243 avatar Mar 02 '24 10:03 Shadow243

fwiw it seems 4bc4cea reverts the previous commits in hm-jmap

We started with your commits then added another, we now have your 4 commits plus 1(5 commits)

yes, but unless i'm mistaken and dont understand the github UI anymore, if you look at the actual PR contents on https://github.com/cypht-org/cypht/pull/909/files there's only a oneliner change which comes from 4bc4cea, and all the other changes from the previous 4 commits are reverted in it... so the complete PR doesn't actually contain 'my commits'

landryb avatar Mar 04 '24 07:03 landryb

@landryb is right - the original commits were reverted as part of another one - namely, this one: https://github.com/cypht-org/cypht/pull/909/commits/4bc4cea2d7f020f74419289944959458a3d11313

@Shadow243 can you please revert that and start with the original 4 commits and then introduce the changes you want? I think we should address the commenting of the isPrimary check - if that's not needed, just remove the code.

kroky avatar Mar 04 '24 10:03 kroky

Copy that. Changes separated here: https://github.com/cypht-org/cypht/pull/909/commits/e9cecf960c4fd180e873bbbea038a5a7e50b5b50

Shadow243 avatar Mar 05 '24 02:03 Shadow243

Thanks @Shadow243!

@landryb do you plan to push more commits here or we can merge now?

kroky avatar Mar 05 '24 12:03 kroky

i havent been able to test more jmap since 1.5 year, so dont wait for me :) hopefully someday i'll be able to retest cypht against stalwart-jmap...

landryb avatar Mar 05 '24 14:03 landryb