improve compatibility with stalwart-jmap

[landryb]

Pullrequest

work in progress, fixing the issues i described in #180. With that PR i can list mails in the INBOX, but clicking on a mail sometimes crashes stalwart-jmap. Still digging..

• apiUrl is a full url, the current code does something weird
• don't escape forward slashes when sending json, otherwise it returns a 400 code with urn:ietf:params:jmap:error:notRequest
• messageId/From/To might be null/empty
• isPrimary isnt mentioned anymore in https://jmap.io/spec-core.html, primaryAccount should be used

[marclaporte]

Merci @landryb !

[marclaporte]

@landryb Do you want me to merge this in, or wait for more?

[landryb]

i dont think it's in a mergeable state, and im not going to have time to dig more in the coming weeks.

If you look at the actual diffs, some commits might be cherrypickables as not having side effects, but some are probably breaking support for cyrus or fastmail. They're here to show what i did to have something that 'at least managed to talk to the jmap server' but it is far from fully working. Was expecting @jasonmunro to have a look and take that as a start :)

[marclaporte]

@landryb I don't think Jason will have time soon to take a look. As a community, we'll focus on releasing Cypht 1.4 and get through these great contributions at https://github.com/jasonmunro/cypht/pulls in coming weeks/months.

This being said, I do want to get great JMAP support in Cypht, so we'll get back to it at one point. Any time you may have is greatly appreciated.

[marclaporte]

@landryb Cypht 1.4.0 has been released.

Any chance to resume efforts on this?

Thanks!

[landryb]

i doubt so right now, maybe when i resume work on porting stalwart 0.3.1..

[marclaporte]

The Stalwart Mail Server is progressing very well and is now at v0.3.7 https://github.com/stalwartlabs/mail-server/commits/main

[landryb]

i know, but my last attempts at updating to 0.3.6 were failed due to tight dependencies on non-released/versioned crates... guess i'll retry someday in the future.

[marclaporte]

ok, @Yannick243 will review our JMAP support (I don't know which reference server he will pick)

[marclaporte]

@landryb Now is a good time as @Shadow243 and @Yannick243 are actively working on JMAP support.

[marclaporte]

@Shadow243 @Yannick243 This is taking too long. JMAP support doesn't need to be perfect. Just make a commit if it's better than what is there now. Commit early, commit often! http://www.catb.org/~esr/writings/cathedral-bazaar/cathedral-bazaar/ar01s04.html

[marclaporte]

@landryb @Yannick243 @Shadow243 @josaphatim "This branch has conflicts that must be resolved"

[Shadow243]

All these changes have been merged here: https://github.com/cypht-org/cypht/pull/909

@landryb @Yannick243 @Shadow243 @josaphatim "This branch has conflicts that must be resolved"

[landryb]

closing, superseded by #909