cypht
cypht copied to clipboard
Login page rework
Pullrequest
Issues
- [X] The The login page UI
Checklist
- [X] None
Screenshots
How2Test
- [X] Just try to login and see the new design
Todo
- [X] Propose any other change to this proposal
I think this looks great, but it needs a couple fixes and I would prefer to make this optional based on a site configuration value. I will definitely use it for my personal site but I would prefer to keep the original plain login as the default and sites can opt-in to use the fancy version.
I did not test the recaptcha module set yet to see if it lines up ok but I can do that after we sort out the issues. Specifically the way the 2 image files are being included is incorrect. In order to work with different site setups includes should be prefixed with the WEB_ROOT constant, and assets should be placed in a module set directory. So please move both images to
modules/core/assets/
and change the URLS to:
src="'.WEB_ROOT. 'modules/core/asset/images/logo.svg"
url('.WEB_ROOT.'modules/core/asset/images/cloud.png);'
Note you have to run the config_gen.php script for the assets to be properly copied over to the production version of the site. Thanks!
Now everything follow your guidance. Thank you @jasonmunro . Next is to know how are we going to make it optional, maybe we need to add switch button somewhere and a file or database entry to save the user setting so he may switch between the login screen accordingly...
Now everything follow your guidance. Thank you @jasonmunro . Next is to know how are we going to make it optional, maybe we need to add switch button somewhere and a file or database entry to save the user setting so he may switch between the login screen accordingly...
This does not need to be a user setting but a site level setting. Lets add it to the hm3.ini file, then use that to determine which login page to show.
I got the point. I am going to work on it soon and give you update
@jasonmunro the login page UI is know configurable.
Thanks