cypht
cypht copied to clipboard
Decide if composer.lock should be tracked in Git (or stay with composer.lock in .gitignore)
https://stackoverflow.com/questions/12896780/should-composer-lock-be-committed-to-version-control
https://search.brave.com/search?q=composer.lock
composer.lock is now in https://github.com/jasonmunro/cypht/blob/master/.gitignore
Related: https://github.com/jasonmunro/cypht/issues/311
Related chat thread on Gitter: https://gitter.im/cypht-org/community?at=62fa629511a6a83d040e77fb
Removing composer.lock has caused an issue with install. As composer.json contains the pre install and pre update commands composer check-platform-reqs, composer install expects a lockfile to be present.
I'm a neophyte with composer and stuff, so I worked around this by replacing the commands in pre-install and pre-update with echo hi and then composer install correctly generated the lockfile.
Removing composer.lock has caused an issue with install. As composer.json contains the pre install and pre update commands
composer check-platform-reqs,composer installexpects a lockfile to be present.
I'm having this same issue when trying to update.
Related: https://github.com/jasonmunro/cypht/pull/632/files
For the record, composer.lock was removed here: https://github.com/cypht-org/cypht/commit/131daacbeb765671ad6d0c90fb4085cb2c9c2eae
And it's highly likely we will resume maintaining composer.lock in Git
composer.lock is now back in the code base: https://github.com/cypht-org/cypht/commit/58f007a3240d4a06cc806982fc3bc37f7b6d9112