cypht icon indicating copy to clipboard operation
cypht copied to clipboard

Deleting an account messes up the list of folders in "Everything", and the special folders

Open marclaporte opened this issue 2 years ago • 7 comments

I deleted an account (both SMTP and IMAP), and the my "Everything" section has some folders it didn't have before.

Looks like the deletion has shifted the folders as if they are using IDs that change.

1st challenge is to reproduce the bug:

  1. Add many IMAP and SMTP accounts
  2. Configure Combined Views https://github.com/jasonmunro/cypht-website/issues/25
  3. Delete an IMAP and SMTP account
  4. Check if Combined View has changed

marclaporte avatar Jun 26 '22 18:06 marclaporte

2022-07-10_140800

marclaporte avatar Jul 10 '22 18:07 marclaporte

There was an attempt to solve but was reverted because of unwanted side-effects: https://github.com/jasonmunro/cypht/pull/454

marclaporte avatar Jul 14 '22 21:07 marclaporte

@henrique-borba I deleted an IMAP account, and I expected this would delete the associated folder. It looked like it worked because they were no longer listed. But later, when I re-added the IMAP account, the folders came back. So I interpret that they were not deleted but orphaned.

marclaporte avatar Jul 31 '22 17:07 marclaporte

@henrique-borba https://github.com/jasonmunro/cypht/issues/380

marclaporte avatar Jul 31 '22 19:07 marclaporte

@henrique-borba A good question for you here: https://github.com/jasonmunro/cypht/pull/591

marclaporte avatar Aug 12 '22 18:08 marclaporte

So we should avoid re-using IDs for

  • Servers (IMAP, JMAP, SMTP)
  • Profiles
  • Folders

What else?

marclaporte avatar Aug 19 '22 14:08 marclaporte

Henrique is working to move everything to stable IDs: https://github.com/jasonmunro/cypht/pull/625

marclaporte avatar Sep 23 '22 19:09 marclaporte

Solved for Cypht 2.0: https://github.com/cypht-org/cypht/pull/625

marclaporte avatar Feb 16 '24 12:02 marclaporte