Aleksa Sarai
Aleksa Sarai
@cfs-pure No I would need to reimplement the behaviour of #9078 specifically for the new TX types needed for our renameat operations, which is going to be a little complicated...
I guess we should return `-EINVAL` if you have `flags != 0` with `renameat2` but without the new feature being enabled in the pool? What should the feature be called...
@behlendorf As far as I can tell, #9078 actually always activates it (`zil_create` will activate the feature so long as it's enabled and `dmu_objset_type(zilog->zl_os) != DMU_OST_ZVOL`). Do you want me...
@behlendorf One issue I had is that all of the ZFS features are defined in `zfeature_common.c` which means that FreeBSD will think it supports this feature even though it doesn't....
@behlendorf > If that's not practical, then we can always wrap the feature registration with an if !defined(__FreeBSD__). Yeah I've just wrapped it in `#ifdef __linux__`. It would be non-trivial...
I'm reworking this PR to correctly enable the features (as well as a general rebase -- I've pushed the current WIP) and it just occurred to me that having one...
CI failure is caused by one of the test vectors not being updated with the new `private-registry-mirrors` member. ``` 09:36:45 ---------------------------------------------------------------------- 09:36:45 FAIL: docker_cli_events_unix_test.go:390: DockerDaemonSuite.TestDaemonEvents 09:36:45 09:36:45 [dd85c3b245ad7] waiting for...
Aside from a :+1: from myself (and it's great to see that this is going to be solved), I'd like to point out that in my experience this issue causes...
NACK. The semantics of `runc create` and `runc start` are defined by the spec. There is no mechanism for us to have a timeout (nor should there be one built-in...
> Perhaps what we should do is to try using device path set in spec, in case /dev/char/MM:mm is not found. Hmmm. This would work for most device configurations (though...