Aleksa Sarai

Results 790 comments of Aleksa Sarai

In particular, the fact that `github.com/openSUSE/umoci` actually contains anything is *ridiculous*.

The issue is that `umoci unpack` has to create a `config.json` (an OCI runtime-spec configuration file) which means that we have to generate said file for whatever operating system the...

I would be happy to do it, though I would need some guidance as to what the right conversions are for images to runtime-specs for each individual platform. My guess...

Since you have an example config, I guess there are programs which generate these configs already? If so we can probably just use their defaults (assuming they're Apache-2.0-compatibly licensed ofc)...

I still need some kind of spec or other documentation explaining what the relevant fields and labels are so we can convert them. By the way, `rspec.VxWorks` doesn't exist in...

You need to add a `Signed-off-by:` line to your commit(s) which indicates that you attest the [Developer Certificate of Origin](https://developercertificate.org/) a statement about your contributions that you *must read* before...

Sorry for not taking a look earlier, I was on leave for a while and there were other issues I had to work on. Thanks for reworking this to be...

Healthchecks aren't part of the OCI image-spec at the moment, and [buildah actually ignores healthcheck options if generating OCI images](https://github.com/containers/buildah/blob/cca320309f2a059f5c105cdfb10e94481c385edf/config.go#L569). Maybe we could provide them as annotations or something, but...