vue-translation-manager
vue-translation-manager copied to clipboard
v2.0.0
This is the draft PR for v2.0.0. The new changes can be seen in the CHANGELOG.md
.
Here are the things that still have to be done:
- [ ] Handle literals in
script
blocks - [ ] Fix coding style issues
- [ ] Fix failing tests
- [ ] Make it possible to not translate a specific string in interactive mode, e.g. by pressing
Esc
Tested this on Node v16.13.1 in my project. I get crashes on these lines:
- vue-translation-manager/src/index.js:159
- vue-translation-manager/src/util.js:17:23
It seems that it assumes that node.value is always string, and doesn't handle numbers, boolean etc. Might this be a change in recent NodeJS?
It's trying to do trimStart() on this node.value:
<ref *2> Node {
type: 'Literal',
value: true,
and trim() on this:
<ref *2> Node {
type: 'Literal',
value: 1,
raw: '1',