Sangwhan "fish" Moon
Sangwhan "fish" Moon
This patch may need extra work if we land #23.
Is this still an issue? I'm unable to reproduce the build failure on Ubuntu 18.04.
Still unable to repro.
@AndreyBozhko do you have a test case that fails due to this? While it's faithful to the paper, the regression being around for almost 11 years could mean that certain...
I cannot reproduce this on macOS 10.13.6 with Apple LLVM version 9.0.0 (clang-900.0.39.2).
Thank you for the pull request. I'll review this and your other PRs and try to land the patches if they look good.
Which Xcode/clang version were you using to trigger this problem? This looks like it'd be fine for clang, but I'll have to check how it works with gcc on macOS.
Apologies; I wasn't too clear on the repro steps. This seems to only happen when trying to install within RStudio (1.0.143). I tried reproducing it on a command line installation...
@kanghyojun 님이 맞는지 모르겠습니다만, 리뷰 부탁드립니다.
만약에 스포카에서 더 이상 사용/유지보수하지 않는 코드베이스이 저희가 부담을 가하고 있다면, commiter/reviewer로 넣어주시고 저희쪽에서 유지 보수 부담을 가져갈 의향도 있습니다. (저희쪽에선 적극적으로 활용중입니다.) @dahlia 님 어떠신지요?