fledge icon indicating copy to clipboard operation
fledge copied to clipboard

What if someone uses --- several times in a commit message

Open maelle opened this issue 3 years ago • 4 comments

should there be some sort of warning

maelle avatar May 12 '22 09:05 maelle

This is a feature.?

krlmlr avatar May 12 '22 09:05 krlmlr

yes, but a quite niche one

maelle avatar May 12 '22 10:05 maelle

Three dashes indicate end of useful contents. Is it similar to "what if somebody uses multiple # in a comment"?

krlmlr avatar Jul 25 '22 16:07 krlmlr

I am no longer sure there should be a warning in this case. The current behavior is fine.

message <- "lalalala\n\n---\n\nblablabla\n\n---\n\nblop"
cat(message)
#> lalalala
#> 
#> ---
#> 
#> blablabla
#> 
#> ---
#> 
#> blop
fledge:::remove_housekeeping(message)
#> [1] "lalalala\n"

Created on 2022-07-29 by the reprex package (v2.0.1)

maelle avatar Jul 29 '22 11:07 maelle

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

github-actions[bot] avatar Aug 30 '23 00:08 github-actions[bot]