What about non GitHub repos

Open maelle opened this issue 3 years ago • 5 comments

Should fledge really be only closely coupled to GitHub.

Apr 08 '22 14:04 maelle

The default can be GitHub, we could offer a fallback for non-GH repos. Low priority, also how to detect GH Enterprise?

Apr 09 '22 05:04 krlmlr

Short-term, add a note that GitHub usage is assumed for the release functions.

Apr 21 '22 14:04 maelle

Noting that is_merge_commit() only recognizes the pattern for GitHub PRs so that is where the "filtering" happens.

Aug 25 '22 12:08 maelle

probably some getwd() clash

Aug 25 '22 14:08 maelle

Maybe after #686 is merged in its current state, a new PR should focus on this issue: making sure the release functions don't fail for non GitHub repos.

A short-term fix would be to just not create PRs for non GitHub repos. But eventually, should we support the opening and merging of PR equivalents on at least GitLab?

Jul 17 '23 10:07 maelle