fledge icon indicating copy to clipboard operation
fledge copied to clipboard

Add a switch to submit_cran() in release()

Open maelle opened this issue 3 years ago • 5 comments

Like an environment variable JUST_EXPERIMENTING or so. :sweat_smile:

maelle avatar Apr 07 '22 07:04 maelle

This is very relevant in the broader context of testability. I think we need to create internal APIs for everything that is external:

  • GitHub (#267)
  • CRAN

For testing we would switch to mock implementations of these external components.

krlmlr avatar Apr 09 '22 06:04 krlmlr

Noting that for GitHub PR/issue API data, we have mock files for tests.

maelle avatar Aug 25 '22 12:08 maelle

What kind of mocking are you envisioning for testing auto.R? Mock files and environment variables to not run some code, or something like https://webfakes.r-lib.org/?

maelle avatar Aug 25 '22 12:08 maelle

I think I'm seeing some incompatibility between httptest::with_mock_dir() and with_repo() :thinking:

maelle avatar Aug 25 '22 14:08 maelle

https://github.com/nealrichardson/httptest/issues/74

(good to know if we decide to use httptest when testing bigger parts of the code than what we've done currently -- which is why we hadn't encountered this problem)

maelle avatar Aug 25 '22 14:08 maelle

This is about a specific implementation detail, we still want to think about testing. OTOH, the automated release process is "tested" every time somebody uses it.

Let's revisit this when we make a bigger attempt at testing "everything".

krlmlr avatar Feb 04 '23 14:02 krlmlr