fledge icon indicating copy to clipboard operation
fledge copied to clipboard

ropensci's `pkgcheck` action

Open pat-s opened this issue 3 years ago • 7 comments

https://ropensci.org/blog/2022/02/01/pkgcheck-action/

Might work well within pre_release() from the f-27-automation branch.

pat-s avatar Feb 01 '22 11:02 pat-s

Are you suggesting to run pkgcheck locally as part of pre_release() ?

krlmlr avatar Feb 17 '22 19:02 krlmlr

As an action, as advertised.

pat-s avatar Feb 18 '22 22:02 pat-s

What would the integration look like?

krlmlr avatar Feb 19 '22 03:02 krlmlr

Add WF YML during pre_release(), remove in post_release(). Haven't put much thought into it yet, though.

pat-s avatar Feb 21 '22 14:02 pat-s

You can enable workflows on cran-* branches only, fledge won't need to do anything here. It seems worth documenting this pattern.

krlmlr avatar Feb 22 '22 10:02 krlmlr

Yes, I am aware. My idea was to reduce the amount of static YAML files and only have this action definition existing in the branch on purpose.

I think there might be potential benefits to only have yaml files present that continuously do action on the current repo state. Otherwise one might loose overview which action actually runs when. Also given that pre_release() is doing similar "set up and remove" things anyhow.

Just a vague idea though, no strong opinion...

pat-s avatar Feb 23 '22 09:02 pat-s

Otherwise one might loose overview which action actually runs when.

Off-topic but this sounds like a good idea for some sort of browser extension @pat-s (to get a diagram or so when clicking on the .github folder in the GitHub interface) :thinking:

maelle avatar Apr 21 '22 14:04 maelle