fledge icon indicating copy to clipboard operation
fledge copied to clipboard

experiment with less resource wasting

Open maelle opened this issue 4 years ago • 5 comments

Fix #135

@krlmlr I have been thinking about wasting resources cf https://www.ryanfiller.com/blog/why-my-blog-stopped-using-deploy-previews

With this workflow, to get a preview one adds the "needs-preview" label. I'd like to merge this to then try again as currently I think the PR workflow from master applies? I see the label workflow works but I am not sure it posts the URL as commit status.

maelle avatar Nov 23 '21 10:11 maelle

Ah I think it now really works (the regex in the pkgdown workflow was catching this branch :sweat_smile: )

maelle avatar Nov 23 '21 13:11 maelle

@krlmlr I'm hoping it'd also work for forks.

maelle avatar Nov 23 '21 13:11 maelle

Can we deploy automatically, but only if the documentation changes?

We're still running a huge build matrix...

krlmlr avatar Nov 23 '21 17:11 krlmlr

Can we deploy automatically, but only if the documentation changes?

Do you mean pre-pkgdown building or do you mean post-pkgdown building? It's unclear to me where we'd store information on what the last deploy website and source were. :thinking:

With this change we'd manually decide whether to label the PR as needs-preview so I assume less often than at each commit.

maelle avatar Nov 24 '21 05:11 maelle

We'd assume that gh-pages contains the last deployed website, and deploy to Netlify only if the current state has changes? Of course this requires stable pkgdown builds, which isn't always given.

Let's put this on the backburner for now.

krlmlr avatar Nov 26 '21 07:11 krlmlr