dm icon indicating copy to clipboard operation
dm copied to clipboard

migrated the updated fonts solution from https://github.com/cynkra/cy…

Open talpitoo opened this issue 1 year ago • 5 comments

…nkraweb/issues/662

NOTE: related to https://github.com/cynkra/cynkraweb/issues/662

talpitoo avatar Feb 29 '24 18:02 talpitoo

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app[bot] avatar Feb 29 '24 18:02 aviator-app[bot]

@christophsax @maelle please see my other comment here https://github.com/cynkra/cynkratemplate/pull/52#issuecomment-1971718352

talpitoo avatar Feb 29 '24 18:02 talpitoo

So, building this locally I can't see the text on the cheatsheet. Did the links to the files change in the meantime?

image

Steps

  • install.packages("pkgdown")
  • install.packages("pak")
  • install.packages("servr")
  • pak::pak()
  • devtools::install()
  • pkgdown::build_site()
  • servr::httw("docs")

maelle avatar Mar 04 '24 14:03 maelle

@maelle i don't know where those links are coming from. This PR contains only 3 .woff2 URLs, e.g. https://cynkra.com/assets/css/fonts/1449009/b3ca2df2-7bee-4fc0-84cb-b029b99c3b61.woff2 but your screenshot points to S3. I am not aware of the deeper architecture or cross-referencing other repos, e.g. cynkratemplate if plays a role or not. Maybe it will be okay on production and the S3 URLs appear on local builds only? cc. @christophsax

talpitoo avatar Mar 04 '24 15:03 talpitoo

Maëlle, can you please work with @talpitoo to resolve this?

krlmlr avatar Aug 14 '24 21:08 krlmlr

Currently building the pkgdown website locally.

maelle avatar Sep 17 '24 09:09 maelle

still getting this

image

maelle avatar Sep 17 '24 09:09 maelle

docs-* branch?

krlmlr avatar Sep 17 '24 09:09 krlmlr

I contacted devops via mattermost

maelle avatar Sep 17 '24 09:09 maelle

will open a new pr with a docs- branch

maelle avatar Sep 17 '24 09:09 maelle

#2233

maelle avatar Sep 17 '24 09:09 maelle