feat!: `copy_dm_to()` uses `dm_sql()`. Unique keys (#1887) and autoincrement primary keys (#1725) are created on the database. Data models with cyclic references are supported on databases that allow adding constraints in `ALTER TABLE` statements (at this time, all except DuckDB and SQLite, #664)

Open krlmlr opened this issue 1 year ago • 9 comments

Closes #1887.
Closes #1725.
Closes #847.
Closes #664.
Closes #1385.

Oct 08 '23 19:10 krlmlr

@nbenn @TSchiefer @moodymudskipper: Can you please test this branch to see if it works for your projects that use dm? I'd like to send it to CRAN tomorrow.

There are breaking changes to copy_dm_to(), but we gain dm_sql() and friends that allow finer-grained control over the SQL that writes a dm to a database.

Oct 09 '23 08:10 krlmlr

I just realized that this PR doesn't necessarily have to be a part of tomorrow's CRAN release. This buys us a little more time if things go sideways, which they will, one way or another.

Oct 09 '23 14:10 krlmlr

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.