constructive icon indicating copy to clipboard operation
constructive copied to clipboard

feat: show a console message when using construct_clip()

Open wurli opened this issue 1 year ago • 1 comments

Closes #486

NB, I had some test failures when running locally, but I think they must be due to differences with my setup because they were all about where linebreaks are placed. Here's an example:

Failure ([test-s3-R6ClassGenerator.R:2:3](vscode-file://vscode-app/Applications/Positron.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html#)): R6Class
Snapshot of code has changed:
     old                                                        | new                                                  
[54]     ),                                                     |     ),                                           [54]
[55]     private = list(                                        |     private = list(                              [55]
[56]       queue = list(),                                      |       queue = list(),                            [56]
[57]       length = (function() base::length(private$queue)) |> -       length = (function() base::length(private$ [57]
                                                                -         queue)) |>                               [58]
[58]         (`environment<-`)(                                 |         (`environment<-`)(                       [59]
[59]           constructive::.env(                              |           constructive::.env(                    [60]
[60]             "0x123456789",                                 |             "0x123456789",                       [61]

I assume these won't show up in the CI tests. I'll investigate further when I get a chance.

wurli avatar Sep 26 '24 22:09 wurli

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app[bot] avatar Sep 26 '24 22:09 aviator-app[bot]

Thanks! just a minor adjustment and it's good to go!

moodymudskipper avatar Sep 27 '24 09:09 moodymudskipper

Nice :) What's the adjustment? One for me to make?

wurli avatar Sep 27 '24 16:09 wurli

I had a couple comments in the review above, but I'll handle these on my side, thanks!

moodymudskipper avatar Dec 31 '24 11:12 moodymudskipper