cylon icon indicating copy to clipboard operation
cylon copied to clipboard

Implement Slice, Head and Tail Operation in both centralize and distr…

Open arupcsedu opened this issue 2 years ago • 3 comments

…ibuted environment

Signed-off-by: Arup Sarker [email protected]

arupcsedu avatar Jun 25 '22 16:06 arupcsedu

@arupcsedu can you reformat the code with Google style with 100 characters per line? VS Code should do this automatically once you set the style

nirandaperera avatar Aug 03 '22 21:08 nirandaperera

Sure I will.

On Wed, 3 Aug, 2022 at 5:04 PM, niranda perera @.***> wrote:

@arupcsedu https://github.com/arupcsedu can you reformat the code with Google style with 100 characters per line? VS Code should do this automatically once you set the style

— Reply to this email directly, view it on GitHub https://github.com/cylondata/cylon/pull/592#issuecomment-1204481770, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOGXWTFU4AI6K2RN4FIOUDVXLNG5ANCNFSM5Z2PWEKA . You are receiving this because you were mentioned.Message ID: @.***>

arupcsedu avatar Aug 03 '22 21:08 arupcsedu

I set it with VSCode. But it formats the code to display in the editor. No actual change in the source file.

On Wed, Aug 3, 2022 at 5:05 PM Arup Sarker @.***> wrote:

Sure I will.

On Wed, 3 Aug, 2022 at 5:04 PM, niranda perera @.***> wrote:

@arupcsedu https://github.com/arupcsedu can you reformat the code with Google style with 100 characters per line? VS Code should do this automatically once you set the style

— Reply to this email directly, view it on GitHub https://github.com/cylondata/cylon/pull/592#issuecomment-1204481770, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOGXWTFU4AI6K2RN4FIOUDVXLNG5ANCNFSM5Z2PWEKA . You are receiving this because you were mentioned.Message ID: @.***>

arupcsedu avatar Aug 04 '22 22:08 arupcsedu

@arupcsedu this looks good now. I made some minor improvements. I'll merge this after CI jobs. Thanks for doing this :slightly_smiling_face:

nirandaperera avatar Aug 19 '22 15:08 nirandaperera