cylc-uiserver icon indicating copy to clipboard operation
cylc-uiserver copied to clipboard

aotf: multiple arguments of the same cylc type

Open oliver-sanders opened this issue 4 months ago • 2 comments

The Play mutation has multiple arguments of the CyclePoint type.

https://github.com/cylc/cylc-uiserver/blob/57405fc5ec51c84df92e3a2aeaa5cf48e9eb0345/cylc/uiserver/schema.py#L126-L175

This is correct from a metadata / help text point of view, but it's difficult for the AOTF system to work out which field(s) it should be filling in.

E.g, if I click on a cycle point, the Play mutation will be associated (correct), but which field should it fill in?

  • inital_cycle_point
  • start_cycle_point
  • hold_cycle_point

~Presently it is picking initial_cycle_point which is the first item in the list. However, this is invalid for workflows which have previously run as the ICP cannot be specified on restart.~ [edit, incorrect] Presently it is filling in all fields.

~We could swap the order and put the start cycle point first. That would work better in this scenario (the only scenario in which a cycle point would be visible in the GUI).~

Or perhaps we should just use a different subclass for these fields so it doesn't trip up AOTF in the first place (do we really want the Play mutation to be an option when clicking on a cycle point, is it intuitive what this will do?).

TODO:

  • [ ] Placate AOTF
  • [ ] Remove the hardcoded exception added here

oliver-sanders avatar Oct 15 '25 16:10 oliver-sanders

For me AOTF was filling in all the cycle point fields

MetRonnie avatar Oct 16 '25 09:10 MetRonnie

Aah, all not just the first, that makes more sense (from the AOTF standpoint), but obvs less sense for the play command!

Corrected OP.

oliver-sanders avatar Oct 16 '25 09:10 oliver-sanders