cylc-ui icon indicating copy to clipboard operation
cylc-ui copied to clipboard

Filtering: case sensitivity and family names

Open MetRonnie opened this issue 3 years ago • 2 comments

  • [ ] Filtering in the table/tree views is currently case sensitive. Should this be the case?
  • [x] You can't filter by family name. Should we be able to? #1182

Pull requests welcome!

MetRonnie avatar Jan 20 '22 13:01 MetRonnie

Filtering in the table/tree views is currently case sensitive. Should this be the case?

Options:

  1. case insensitive (OK if caps are infrequently used)
  2. case insensitive, with checkbox to make it case sensitive
  3. "intelligent": if all lowercase: case insensitive; otherwise (any uppercase chars): case sensitive

Options 3 is nice IMO (I use this for vim search). Most of the time it's super convenient, but occasionally you might net more results than you want. (Assumes most search targets are all lowercase, which is reasonable).

You can't filter by family name. Should we be able to?

Yes.

hjoliver avatar Jan 25 '22 02:01 hjoliver

I think "case insensitive, with checkbox to make it case sensitive" is fine (keep it simple). If we want to go advanced with this we would probably do it by supporting regex (e.g. /Foo/I)

I think search should work on all levels of the tree, cycle points and families included.

oliver-sanders avatar Aug 08 '22 16:08 oliver-sanders