cylc-ui icon indicating copy to clipboard operation
cylc-ui copied to clipboard

graph: clear the graph when there is nothing to draw

Open oliver-sanders opened this issue 10 months ago • 2 comments

If there is nothing to draw, the graph view currently preserves the last valid graph. This is a little inconsistent, other views go blank.

I think there have been some issue with differentiating between empty and error states once?

We should allow the graph to go blank and, ideally, leave a placeholder where the graph would be to explain this, however, that is a different issue - cylc/cylc-ui#332.

oliver-sanders avatar Apr 16 '24 10:04 oliver-sanders

I think this is a https://github.com/cylc/cylc-ui/labels/bug because of this from cylc/cylc-uiserver#630

An example. Note the workflow is stopped after having completed, but the task still claims to be running.

20240924_122816

MetRonnie avatar Sep 24 '24 13:09 MetRonnie

I think this is a bug because of this from https://github.com/cylc/cylc-uiserver/issues/630

I don't think that's right.

  • This issue is about clearing the graph when the task pool is empty.
  • The issue you linked was about the task state not being updated before the workflow shut down.

Note that other views (e.g. the tree view) will retain the workflows last known state after it has shut down (similar to the graph view) so if the task has been left in the wrong state, that is a different bug. Possible causes:

  • Scheduler did not send the task state transition before shutting down.
  • UIS did not forward the task state transition due to the workflow shutting down.
  • UI data store did not enact the task state transition due to the presence of the shutdown delta.
  • UI Graph view became decoupled from the UI data store (so the task state change did not happen).

oliver-sanders avatar Sep 24 '24 13:09 oliver-sanders