cylc-ui icon indicating copy to clipboard operation
cylc-ui copied to clipboard

Edit runtime: add trigger action to form

Open MetRonnie opened this issue 1 year ago • 4 comments

Problem

Users may be used to the Cylc 7 trigger-edit functionality, might forget to trigger after submitting the Edit Runtime form.

Proposed Solution

Add a toggle switch for trigger to the form (either top or maybe in the bottom left next to the other form buttons).

image

The problem is making sure the broadcast has happened before the trigger - this is a cylc-flow problem and may depend on https://github.com/cylc/cylc-flow/issues/3329

MetRonnie avatar Jun 20 '23 12:06 MetRonnie

Could be a bit dangerous if you're applying edit runtime to a family?

dpmatthews avatar Jun 22 '23 08:06 dpmatthews

The toggle could only be enabled for tasks

MetRonnie avatar Jun 22 '23 09:06 MetRonnie

It's possible you want to trigger a whole family though. Just add a warning?

hjoliver avatar Jun 26 '23 02:06 hjoliver

Possibly but a bit icky at present.

It is possible to call multiple mutations in a single GraphQL request e.g:

mutation broadcast (...) { result }

mutation trigger (...) { result)

And (when last tested) these mutations are actioned in canon (not in parallel).

However (as identified in the OP), issuing a mutation only queues it on the scheduler, the mutation returns as soon as the command is queued. Due to the scheduler implementation commands should be run in the order they are received providing they only require one action to complete i.e. do not require the involvement of other parts of the main loop which some commands do.

So in theory, this is probably technically possible ATM, however, might not be completely stable in practice until https://github.com/cylc/cylc-flow/issues/3329.

oliver-sanders avatar Jul 25 '23 08:07 oliver-sanders