Graph view: suicide triggers

[MetRonnie]

Currently, suicide triggers are shown in the graph view just the same as normal dependencies, which makes it look like a task depends on itself.

We should either not display suicide triggers or style them differently e.g. dotted line.

Pull requests welcome! This is an Open Source project - please consider contributing a bug fix yourself (please read CONTRIBUTING.md before starting any work though).

[oliver-sanders]

I think we should omit these edges. Suicide triggers will be go away when compat mode is withdrawn so we don't need to invest too much into making them work nicely.

Marking this as a bug, and optimistic tagging against 1.6.0.

[hjoliver]

Currently, suicide triggers are shown in the graph view just the same as normal dependencies, which makes it look like a task depends on itself.

Presumably you mean in cases like foo:fail => !foo

I don't think the current situation is that bad. In a sense, the task does depend on itself here. If foo fails, then foo gets removed.

It would be better to draw the edge differently somehow. But I agree with @oliver-sanders that we shouldn't invest much effort in this, given that suicide triggers are more or less entirely useless in Cylc 8.