cylc-ui
cylc-ui copied to clipboard
Timer Animations Not Synced
Describe the bug
The timer animation can get out of step when comparing graph view and tree views. The clocks look a little out of sync, which I think is acceptable - they are estimates anyway. When holding a running task I think this difference is amplified.
Release version(s) and/or repository branch(es) affected?
Bug noticed when reviewing https://github.com/cylc/cylc-ui/pull/1108
Steps to reproduce the bug
Have both the graph view and the tree view visible. Start a workflow with a task that repeats. hold
a running task in the graph view, the timer animations go off sync, the difference is more amplified on some occasions.
Expected behavior
We would expect the animations to have the same display.
Screenshots
Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md
before starting any work though).
What sort of job duration were you testing with? Because +/- 2sec error will be obvious for a 10sec job, not so much for a 10min job.
When holding a running task I think this difference is amplified.
This shouldn't be possible right? (holding a running task) .. Yes, it shouldn't effect the animation, are animations are refreshed only with updates?
What sort of job duration were you testing with?
It was a script = sleep 50
.
This shouldn't be possible right? (holding a running task) ..
Although the hold won't affect the running task, the held state will apply for retries?
Yes, it shouldn't effect the animation, are animations are refreshed only with updates?
I think if possible, the animations should come from a single source of truth, I noticed it in this case but I'm not sure if there are other cases where it might be a problem. On the whole, I think this is a very minor problem.