cylc-flow
cylc-flow copied to clipboard
Graph Section Comments Break Validation
A multiline graph containing a comment containing a set of quotes like the termination of the graph section causes a validation failure: True for both ''' and """
Reproducible Example
#!jinja2
[scheduler]
allow implicit tasks = True
[scheduling]
[[graph]]
R1 = '''
# ''' Surely Cylc Shouldn't see this as the end of the graph?
foo
'''
Expected Behaviour
Quotation marks in comments ought to be ignored.
After discussion with @oliver-sanders I'm not as sure that this is wrong as I was.
Posted to Element https://matrix.to/#/!gMuCeOJBhYqgWDGwnR:matrix.org/$174704625133144FCWJk:matrix.org?via=matrix.org
I'm not entirely sure there's a right answer to that question. We just have to pick one way or the other and stick with it.
We support comments inside multi-line strings, so this clearly OK:
"""
# one
# two
"""
So, in support of the status quo, shouldn't the following be considered equivalent? (The only difference is a newline that has no meaning in that position, and we're talking stuff that is inside the graph string):
"""
# one
# two"""